makes session cookie secure, httponly and set same site attribute #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makes session cookie secure, httponly and set same site attribute
rafaelbey
reviewed
Oct 4, 2024
|
|
||
| private void makeSessionCookieSecure( ContextHandler.Context servletContext) | ||
| { | ||
| SessionCookieConfig sessionCookieConfig = servletContext.getSessionCookieConfig(); |
There was a problem hiding this comment.
Could this ever be null?
There was a problem hiding this comment.
I have seen "JSESSIONID" getting always created with Dropwizard and Jetty so ideally SessionCookieConfig should not be null.
There was a problem hiding this comment.
As discussed, added null check to avoid potential NPE.
Yasirmod17
previously approved these changes
Oct 16, 2024
Yasirmod17
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.